Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade go-ethereum to match shlib's version #422

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade go-ethereum to match shlib's version #422

wants to merge 1 commit into from

Conversation

konradkonrad
Copy link
Contributor

@konradkonrad konradkonrad commented Nov 23, 2023 •
edited
Loading

shlib/v0.1.14 uses [email protected].

This PR has the change in isolation, so we can debug any incompatibilities as a prerequisite for merging #416

I found the following potential breaking change:

@konradkonrad
Copy link
Contributor Author

Here's the node output from one of the play tasks (play/work/keyper-dkg-works/logs/node-out.txt)

  Block #17:           0xd8b55cefae9a214872c70d75a71d10d37add805c5f28ac933323b9f8aeebf9f9
  Contract call:       CollatorConfigsList#getActiveConfig
  From:                0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266
  To:                  0x8a791620dd6260079bf849dc5567adc3f2fdc318
  Contract call:       CollatorConfigsList#addNewCfg
  Transaction:         0x7de10378070e03911730394d909ecb411f3bfb99349d909d27bb4e7c58c4be8d
  From:                0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266
  To:                  0x8a791620dd6260079bf849dc5567adc3f2fdc318
  Value:               0 ETH
  Gas used:            66543 of 29021656
  Block #18:           0x8965130a9a72ca673c58ffb4a89e16b937809e499684ef1f064c29878824cb01

eth_blockNumber
eth_getLogs
eth_getLogs (2)
eth_blockNumber
eth_call
  Contract call:       AddrsSeq#<unrecognized-selector>
  From:                0x0000000000000000000000000000000000000000
  To:                  0xdc64a140aa3e981100a9beca4e685f962f0cf6c9

  Error: Transaction reverted: function selector was not recognized and there's no fallback nor receive function
      at AddrsSeq.<unrecognized-selector> (src/AddrsSeq.sol:21)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
      at HardhatNode.runCall (/home/konrad/Projects/rolling-shutter/contracts/node_modules/hardhat/src/internal/hardhat-network/provider/node.ts:665:20)
      at EthModule._callAction (/home/konrad/Projects/rolling-shutter/contracts/node_modules/hardhat/src/internal/hardhat-network/provider/modules/eth.ts:356:9)
      at HardhatNetworkProvider._sendWithLogging (/home/konrad/Projects/rolling-shutter/contracts/node_modules/hardhat/src/internal/hardhat-network/provider/provider.ts:144:22)
      at HardhatNetworkProvider.request (/home/konrad/Projects/rolling-shutter/contracts/node_modules/hardhat/src/internal/hardhat-network/provider/provider.ts:121:18)
      at JsonRpcHandler._handleRequest (/home/konrad/Projects/rolling-shutter/contracts/node_modules/hardhat/src/internal/hardhat-network/jsonrpc/handler.ts:191:20)
      at JsonRpcHandler._handleSingleRequest (/home/konrad/Projects/rolling-shutter/contracts/node_modules/hardhat/src/internal/hardhat-network/jsonrpc/handler.ts:152:17)

eth_getLogs
eth_getLogs (2)
eth_blockNumber
eth_getLogs
eth_getLogs (2)
eth_blockNumber
eth_blockNumber (2)
eth_blockNumber (3)
eth_getLogs
eth_getLogs (2)
eth_blockNumber
eth_getLogs
eth_call
  Contract call:       AddrsSeq#<unrecognized-selector>
  From:                0x0000000000000000000000000000000000000000
  To:                  0xdc64a140aa3e981100a9beca4e685f962f0cf6c9

  Error: Transaction reverted: function selector was not recognized and there's no fallback nor receive function
      at AddrsSeq.<unrecognized-selector> (src/AddrsSeq.sol:21)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
      at HardhatNode.runCall (/home/konrad/Projects/rolling-shutter/contracts/node_modules/hardhat/src/internal/hardhat-network/provider/node.ts:665:20)
      at EthModule._callAction (/home/konrad/Projects/rolling-shutter/contracts/node_modules/hardhat/src/internal/hardhat-network/provider/modules/eth.ts:356:9)
      at HardhatNetworkProvider._sendWithLogging (/home/konrad/Projects/rolling-shutter/contracts/node_modules/hardhat/src/internal/hardhat-network/provider/provider.ts:144:22)
      at HardhatNetworkProvider.request (/home/konrad/Projects/rolling-shutter/contracts/node_modules/hardhat/src/internal/hardhat-network/provider/provider.ts:121:18)
      at JsonRpcHandler._handleRequest (/home/konrad/Projects/rolling-shutter/contracts/node_modules/hardhat/src/internal/hardhat-network/jsonrpc/handler.ts:191:20)
      at JsonRpcHandler._handleSingleRequest (/home/konrad/Projects/rolling-shutter/contracts/node_modules/hardhat/src/internal/hardhat-network/jsonrpc/handler.ts:152:17)

@bilbeyt
Copy link
Contributor

bilbeyt commented Dec 1, 2023

We need NomicFoundation/hardhat#4438 to be released to support this newer version.

@konradkonrad
Copy link
Contributor Author

It seems NomicFoundation/edr#444 did fix this incompatibility.

konradkonrad added a commit that referenced this pull request Jul 2, 2024
@konradkonrad
Update hardhat dependency
ac5a0da 
Since upgrading to `[email protected]` the `play` tests were not
compatible anymore (see
#422). On
hardhats side, the problem was addressed in
NomicFoundation/edr#444.
@konradkonrad konradkonrad mentioned this pull request Jul 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@konradkonrad @bilbeyt